add support for kotlin multiplatform #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this commit adds support for most kotlin multiplatform targets including ios, wasm, js, jvm also fixes nanihadesuka#41 all tests have passed compiled for all platform and got successful * setup targets * move tests from androidTest to androidUnitTest sourceSet, some dependencies are android-specific and we cant put it on commonTest sourceSet * moved previews to androidMain sourceSet as it is android-specific * migrated some components to material3 * bumped Kotlin to 2.0.20 * bumped agp to 8.6.0 * remove explicit compose buildFeature declaration as is is no more needed after AGP 8.5.2 * bumped some dependencies to their latest version * get rid on some unused dependencies like appcompat etc.. * use jetbrains compose compiler and jetbrains compose dependencies
|
Also the ":app" module ramains Android only. didn't think it was a good idea to migrate it at this time, maybe in another pull |
|
Wow 🌞 Sorry for the lateness. Looks very promising! Will take a look, and also will look at KMP topics before as I don't have much experience at it to make a proper review. Give me 1 week to look at the PR |
|
Sure, no problem, If you have any questions just ask, I'm already using this in my app, but I had to embed it in this one, so I decided to contribute 😅 |
nanihadesuka
reviewed
Oct 6, 2024
nanihadesuka
reviewed
Oct 6, 2024
nanihadesuka
reviewed
Oct 6, 2024
|
Thanks for the work. I will merge then do a cursory check, update readme & publish it the following weekend |
nanihadesuka
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this commit adds support for most kotlin multiplatform targets including ios, wasm, js, jvm also fixes #41
all tests have passed
compiled for all platform and got successful